Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AUTO] Increment version to 1.3.6-SNAPSHOT #2119

Closed
wants to merge 1 commit into from
Closed

[AUTO] Increment version to 1.3.6-SNAPSHOT #2119

wants to merge 1 commit into from

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

  • Incremented version to 1.3.6-SNAPSHOT.

@opensearch-ci-bot
Increment version to 1.3.6-SNAPSHOT
7655b9a 
Signed-off-by: opensearch-ci-bot <[email protected]>
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team September 29, 2022 00:21
@cwperks
Copy link
Member

cwperks commented Sep 29, 2022

@prudhvigodithi Looks like the . needs to be escaped in the regex for version increment automation.

Relevant line: ant.replaceregexp(match: opensearch_version.tokenize('-')[0], replace: newVersion.tokenize('-')[0], flags:'g', byline:true)

https://github.com/opensearch-project/security/blob/1.3/build.gradle#L388

@prudhvigodithi
Copy link
Member

Hey @cwperks actually the following lines should be removed as there no files included and for the build.gradle the ant.replaceregexp is explicitly added :)
Thank you

@cwperks
Copy link
Member

cwperks commented Sep 29, 2022

Thank you @prudhvigodithi! I will create a PR to remove the unnecessary lines.

@cwperks cwperks mentioned this pull request Sep 29, 2022
Merged
3 tasks
@cwperks cwperks closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwperks @prudhvigodithi @opensearch-ci-bot